fix(lint): os validate and os build resolve a report's dataset through the reading package's declared closure, as the runtime does - #33171

Requested by Tesla · project thread

Fixes #33128

Clause-②: no
Metadata-protocol: none

维护者速读

• 改了什么：多包产物逐包检查时，报表（含 joined 块、列表视图图表、页面图表）引用的 dataset 改为和看板一样按「本包 → 已声明依赖闭包里唯一持有者」解析；依赖包的数据集不再被 os validate / os build 误报 chart-dataset-unknown。
• 为什么改：运行时本来就按 callerPackage 从依赖闭包解析报表的数据集并正常返回，作者期却只看本包自己的 datasets，有效的模块化应用构建不过（看板那一半已由 fix(lint)!: os validate and os build resolve a dashboard's dataset through the reader's declared closure, as the runtime does #33121 修好，这是报表那一半）。
• 风险与回滚：只放行运行时本来就放行的引用；闭包外的持有者、闭包内两个持有者仍然报错（现在会点名持有者并给出可行改法），发布门不变，运行时不变。回滚即 revert 本 PR。
• 先看：packages/lint/src/validate-chart-bindings.ts 的 resolveDataset（拒绝与警告两支）和 indexDatasets（改读看板同一份解析结果）。
• 两分钟验证：pnpm --filter @objectstack/lint exec vitest run --maxWorkers=2 src/validate-chart-bindings.test.ts，预期 91/91 通过，其中 [#33128] 一组 11 条。
• 需要你做的：无，席位落地。

Red lines

1. Resolution is never loosened. The binding resolves through indexArtifactDatasetResolution, the resolution widget-dataset-unknown and report-filter-field-unknown already read; this PR adds no second walk and no wider reach. A dataset only an undeclared package holds stays refused: REFUSES a report over a dataset only an UNDECLARED package holds, naming the holder and the dependency to declare, and the CONTROL half of ACCEPTS the same dependency’s dataset on a joined block, a list-view chart and a page chart. The phase-1 one-holder tests are not touched (packages/core, packages/objectql are outside the diff); bare-name URL behaviour is not touched (no runtime file in the diff).
2. Ambiguity is reported, never guessed. REFUSES a name two packages of the closure hold, naming both: nothing picks one (red line 2) asserts the code, the severity, the path and the message's first clause naming both holders, and that the report's positions are judged against neither. REPORTS, not refuses, when the reader declares a dependency the artifact does not carry; never softens an ambiguity keeps it an error when an outside dependency is declared. Ablation A4 (the resolver picks the first holder) turns both red.
3. Independently releasable. One package (@objectstack/lint, patch), no runtime answer moves, nothing in this diff waits on a sibling card. No migration: nothing stored changes. No behaviour moves between layers, so no ADR-0087 entry is owed (the authoring gate stops refusing what the runtime serves).

What changes

Why every surface of this rule and not only reports: every reader it judges sends its own served package as callerPackage (DatasetReportRenderer, ObjectChart, the list view's chart in objectViewListRenderer.tsx), and the dataset doors resolve the name from that package by ADR-0150 D3: "?callerPackage=P names the package of the item that reads the name (a dashboard, report or chart of P) … The name resolves from P by D3" (ADR-0150, amendment note of 2026-11-11). On the per-package pass every item is the judged package's, so one resolution serves all three surfaces.

Which resolver: the order points at packages/core/src/package-scoped-resolution.ts. PR #33121's dashboard half resolves with indexArtifactDatasetResolution (packages/lint/src/validate-widget-bindings.ts), over packageResolutionClosure (@objectstack/metadata-core); core's module holds the D3 rule's runtime vocabulary, which the lint does not call. This PR imports that same lint function and its two wording functions; nothing is copied, and neither package-scoped-resolution.ts nor validate-widget-bindings.ts is edited.

validate-report-runtime-filter.ts (review nit N1 on PR #33121), re-judged: it does not share the defect. It has read indexResolvableDatasets, the same closure-aware index, since #33121, so a report's runtimeFilter over a declared dependency's dataset already resolves that dataset. No change. Its per-package pass leaves a refused name unjudged, and chart-dataset-unknown now carries that verdict with the reason; the union run still judges the filter.

Clause-② reads no: the lint now accepts only what the runtime and ADR-0150 D3 already accept (the quotation above); no published contract refuses it. Metadata-protocol reads none: no key, value or type is added or removed, no meaning or default changes (the authoring gate stops a false refusal); copied from the claim.

Tests

packages/lint/src/validate-chart-bindings.test.ts, one new top-level describe, [#33128] chart-dataset-unknown resolves through the reading package’s declared closure (11 cases):

• ACCEPTS a report over the dataset of a package it declares, and judges its positions against it
• resolves a TRANSITIVE dependency’s dataset (the declared closure, ADR-0141)
• ACCEPTS the same dependency’s dataset on a joined block, a list-view chart and a page chart (CONTROL: each refused without the dependency)
• REFUSES a report over a dataset only an UNDECLARED package holds, naming the holder and the dependency to declare (code, severity, where, path, full message)
• names the move, never the dependency, when the holder already depends on the reader (a cycle)
• REFUSES a name two packages of the closure hold, naming both: nothing picks one (red line 2)
• the reading package’s own dataset wins a name its dependency also holds (ADR-0150 D3 step 1)
• REPORTS, not refuses, when the reader declares a dependency the artifact does not carry; never softens an ambiguity
• a name NO package declares, and any stack judged without the artifact, keep the unchanged sentence
• the union run reads every body, as the dashboard rule does: a residual top-level datasets no longer hides the module’s own (CONTROL: the app's per-package pass is refused with the cycle hint)
• reaches the rule table the per-package pass runs; the publish door’s snapshot is unchanged

Ablations (mutation through scripts/ablation-replace.mjs, red seen, restored with blob == HEAD and git diff HEAD empty; the suite imports src/, so no dist leg):

ablation-replace: ok mutation landed: anchor 1 -> 0, blob 0180ff82bd96 -> 5f0360b3f627
     × ACCEPTS a report over the dataset of a package it declares, and judges its positions against it
     × resolves a TRANSITIVE dependency’s dataset (the declared closure, ADR-0141)
     × ACCEPTS the same dependency’s dataset on a joined block, a list-view chart and a page chart
     × a name NO package declares, and any stack judged without the artifact, keep the unchanged sentence
     × the union run reads every body, as the dashboard rule does: a residual top-level `datasets` no longer hides the module’s own
     × reaches the rule table the per-package pass runs; the publish door’s snapshot is unchanged
      Tests  6 failed | 85 passed (91)
ablation-replace: ok restored: blob == HEAD (0180ff82bd96) and `git diff HEAD` is empty

ablation-replace: ok mutation landed: anchor 1 -> 0, blob 0180ff82bd96 -> 6cc59c84f5e3
     × REFUSES a report over a dataset only an UNDECLARED package holds, naming the holder and the dependency to declare
     × names the move, never the dependency, when the holder already depends on the reader (a cycle)
     × REFUSES a name two packages of the closure hold, naming both: nothing picks one (red line 2)
     × REPORTS, not refuses, when the reader declares a dependency the artifact does not carry; never softens an ambiguity
     × the union run reads every body, as the dashboard rule does: a residual top-level `datasets` no longer hides the module’s own
      Tests  5 failed | 86 passed (91)
ablation-replace: ok restored: blob == HEAD (0180ff82bd96) and `git diff HEAD` is empty

ablation-replace: ok mutation landed: anchor 1 -> 0, blob 0180ff82bd96 -> 4e44dcc56680
     × REFUSES a report over a dataset only an UNDECLARED package holds, naming the holder and the dependency to declare
     × names the move, never the dependency, when the holder already depends on the reader (a cycle)
     × REFUSES a name two packages of the closure hold, naming both: nothing picks one (red line 2)
     × REPORTS, not refuses, when the reader declares a dependency the artifact does not carry; never softens an ambiguity
     × the union run reads every body, as the dashboard rule does: a residual top-level `datasets` no longer hides the module’s own
     × reaches the rule table the per-package pass runs; the publish door’s snapshot is unchanged
      Tests  6 failed | 85 passed (91)
ablation-replace: ok restored: blob == HEAD (0180ff82bd96) and `git diff HEAD` is empty

ablation-replace: ok mutation landed: anchor 1 -> 0, blob 1254a2305c2e -> 0cdf4a3f09e9
     × REFUSES a name two packages of the closure hold, naming both: nothing picks one (red line 2)
     × REPORTS, not refuses, when the reader declares a dependency the artifact does not carry; never softens an ambiguity
      Tests  2 failed | 89 passed (91)
ablation-replace: ok restored: blob == HEAD (1254a2305c2e) and `git diff HEAD` is empty

Acceptance notes

• Measured first at origin/main 47f6c93, validateChartBindings on the per-package shape (module com.example.m declares com.example.d, which holds ds; the module's report reads ds): one chart-dataset-unknown error, "binds dataset "ds", which resolves to no declared dataset — there is no data to render." / "Declared datasets: (none)."
• Grep of the surface for ruling|Ruling-ref|maintainer|⛔: validate-chart-bindings.ts:93 names the maintainer ruling on chart-field-unknown (presentation positions warn, query positions error); this diff moves no position's severity. validate-report-runtime-filter.ts: no hit. package-scoped-resolution.ts: not edited; no export was needed.
• validate-report-date-range.ts (not in this surface) indexes stack.datasets alone, so on the per-package pass a report's dateRange over a declared dependency's dataset is not judged there; the union run judges it. Not a false refusal and no verdict lost; noted, not filed.
• Filter keys on a dependency's dataset (both report-filter-field-unknown and the dashboard twin): the per-package object graph holds the package's own objects, so a key on an object the dependency holds is skipped on that pass and judged on the union run. Probe at this head: a report over the dependency's dataset with runtimeFilter: { nope: 'x' } gives no per-package finding. The twin behaves the same; noted, not filed.
• A top-level residual report beside a composition is judged on the union run against every body, as the dashboard rule judges a residual dashboard since spec+cli: an artifact's per-package checks refuse an action → flow and a widget → dataset reference that another package of the SAME artifact satisfies (the #18202 family, for flows and datasets) #25514; unchanged in kind, now the same for both rules.

Verification

All at head 60edc5ee, worktree off origin/main 47f6c93 (git merge origin/main: already up to date).

• pnpm --filter @objectstack/lint build && … typecheck && … test (under os-verify-lock): VERDICT command-exit 0, Test Files 208 passed (208), Tests 8836 passed (8836); typecheck is tsc --noEmit && pnpm check:test-typecheck.
• pnpm lint (repo-wide eslint): exit 0.
• node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack: 59 families, each run with stdin from /dev/null, exit codes captured before any pipe; --ran: "59 derived famil(ies) accounted for — 59 run, 0 NOT-MEASURED (a DERIVED zero — all 59 recorded an exit code and none of them is 3)". Three first runs were prerequisite failures, not reds, and are recorded at their rerun: check-plugin-teardown-shape.mjs --self-test exit 3 on the shallow clone (its pinned fixture commit unreachable), exit 0 after git fetch --unshallow; check:dts-closure exit 1 and check:dual-build-cjs-loads exit 3 (PREREQUISITE NOT MET, no dist/) after an OS_SKIP_DTS=1 CLI build of mine, both exit 0 after a full pnpm build (VERDICT command-exit 0).
• Dogfood battery: n/a, no ! in the title and no (narrowing) arm.

# this head
mode=declared exit=0
  ✓ Validation passed (147ms)
mode=undeclared exit=1
  • package 'com.qa.rpt.sales' — report "rpts_books_by_genre": dataset "rptl_book_metrics" is held by package "com.qa.rpt.lib", outside the declared dependency closure of package "com.qa.rpt.sales", so the installed report's read of it is refused 409 (ADR-0150 D3).
      fix: Declare the dependency: add "com.qa.rpt.lib" to the `dependencies` of package "com.qa.rpt.sales" (ADR-0141), or move the dataset into "com.qa.rpt.sales".
      rule: chart-dataset-unknown  at reports[0].dataset

# A1 (the BASE index) in dist: lint rebuilt, preflight "marker present in 4 built files"
mode=declared exit=1
  • package 'com.qa.rpt.sales' — report "rpts_books_by_genre": binds dataset "rptl_book_metrics", which resolves to no declared dataset — there is no data to render.
      rule: chart-dataset-unknown  at reports[0].dataset
# restored: blob == HEAD, rebuilt, preflight --absent "marker absent from all 20 built files", tree clean

Human Minimum

• 1. Schemas start as Zod; packages/spec holds no runtime logic.
• 2. Every name I added uses the casing for its kind.
• 3. No formatter ran; pnpm lint passes.
• 4. One issue, one branch off an up-to-date main, one pull request.
• 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset.
• 6. packages/spec touched: its generated artifacts are regenerated and committed. (not touched)
• 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
• 8. Title, body and comments are in English.
• The Before Submitting list in CONTRIBUTING.md is done.

Generated by Claude Code